Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add a deprecation badge to legacy stats setting #155688

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[Discover] Add a deprecation badge to legacy stats setting #155688

merged 2 commits into from
Apr 25, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 25, 2023 •
edited
Loading

Summary

We are adding a deprecation badge in 8.8 and removing this setting in 8.9 #155503

Screenshot 2023-04-25 at 10 28 21

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 25, 2023
@jughosta jughosta self-assigned this Apr 25, 2023
@jughosta jughosta marked this pull request as ready for review April 25, 2023 08:32
@jughosta jughosta requested a review from a team as a code owner April 25, 2023 08:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works as expected ... good practice 👍

@jughosta jughosta requested a review from a team as a code owner April 25, 2023 08:53
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 157.4KB 157.4KB +70.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 353.1KB 353.1KB +70.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

gchaps
gchaps approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM

@jughosta jughosta merged commit 61b56ce into elastic:main Apr 25, 2023
@jughosta jughosta deleted the add-deprecated-note branch April 25, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jughosta @elasticmachine @kibana-ci @kertal @gchaps