Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Plugin Initialize - Updating logs-cloud_security_posture.findings_latest-default index mappings #151460

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

kfirpeled
Copy link
Contributor

@kfirpeled kfirpeled commented Feb 16, 2023

Summary

fixes #151439

In the following video you can see a demonstration of the bug reproduction and how it is being fixed on the next plugin's initialize call (on kibana server start and on package installation)

The video shows:

  1. bug reproduction (missing mappings for posture_type field causes the dashboard not to appear)
  2. Simulating new package update by adding the mappings manually
  3. Triggering initialize by server restart
  4. Showing update mappings was called (highlighting the log message)
  5. Waiting for new findings on the latest findings index
  6. Problem is solved
bug.fix.-.index.mapping.update.mp4

@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0 v8.8.0 labels Feb 16, 2023
@kfirpeled kfirpeled requested a review from CohenIdo February 16, 2023 15:27
@kfirpeled kfirpeled requested a review from a team as a code owner February 16, 2023 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled kfirpeled merged commit eba0dc6 into elastic:main Feb 20, 2023
@kfirpeled kfirpeled deleted the cspm/bug_fix_update_index_mapping branch February 20, 2023 09:06
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 20, 2023
…sture.findings_latest-default` index mappings (elastic#151460)

(cherry picked from commit eba0dc6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 20, 2023
…ity_posture.findings_latest-default` index mappings (#151460) (#151587)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Cloud Security] Plugin Initialize - Updating
`logs-cloud_security_posture.findings_latest-default` index mappings
(#151460)](#151460)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kfir
Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-20T09:06:09Z","message":"[Cloud
Security] Plugin Initialize - Updating
`logs-cloud_security_posture.findings_latest-default` index mappings
(#151460)","sha":"eba0dc6eb55656a779b90434490109c1c20794b4","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","v8.7.0","v8.8.0"],"number":151460,"url":"https://github.com/elastic/kibana/pull/151460","mergeCommit":{"message":"[Cloud
Security] Plugin Initialize - Updating
`logs-cloud_security_posture.findings_latest-default` index mappings
(#151460)","sha":"eba0dc6eb55656a779b90434490109c1c20794b4"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151460","number":151460,"mergeCommit":{"message":"[Cloud
Security] Plugin Initialize - Updating
`logs-cloud_security_posture.findings_latest-default` index mappings
(#151460)","sha":"eba0dc6eb55656a779b90434490109c1c20794b4"}}]}]
BACKPORT-->

Co-authored-by: Kfir Peled <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Dashboard does not load after upgrade
5 participants