Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KQL] Add case-insensitive config for term/wildcard queries #148916

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Jan 13, 2023

Summary

Part of #55378.

Adds a caseInsensitive option to the KQL parsing options (KueryQueryOptions). When enabled, keyword queries (both wildcard[1] and term[2]) will add the case_insensitive option to enable case-insensitive search.

  1. https://www.elastic.co/guide/en/elasticsearch/reference/8.6/query-dsl-wildcard-query.html#wildcard-query-field-params
  2. https://www.elastic.co/guide/en/elasticsearch/reference/8.6/query-dsl-term-query.html#term-field-params

Checklist

@lukasolson lukasolson added Feature:KQL KQL Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Jan 13, 2023
@lukasolson lukasolson self-assigned this Jan 13, 2023
@lukasolson lukasolson requested a review from a team as a code owner January 13, 2023 19:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal requested a review from a team January 16, 2023 09:23
@kertal
Copy link
Member

kertal commented Jan 16, 2023

It seems we need to also change codeownership to @elastic/kibana-data-discovery
The follow up would be to make use of this change in unified search based queries, right?

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, changes LGTM 👍 I agree with @kertal that we should also look at updating the CODEOWNERS file.

@lukasolson lukasolson added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Jan 17, 2023
@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.2MB 2.2MB +272.0B
Unknown metric groups

API count

id before after diff
@kbn/es-query 249 250 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit 81d5764 into elastic:main Jan 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 20, 2023
@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:KQL KQL release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants