Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@kbn/handlebars] Refactor internal context handling #148029

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[@kbn/handlebars] Refactor internal context handling #148029

merged 1 commit into from
Dec 22, 2022

Conversation

watson
Copy link
Contributor

@watson watson commented Dec 22, 2022 •
edited by kibanamachine
Loading

null

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 22, 2022
@watson watson requested a review from a team as a code owner December 22, 2022 19:44
@watson watson self-assigned this Dec 22, 2022
@watson watson enabled auto-merge (squash) December 22, 2022 19:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +46.0B
uiActionsEnhanced 138.9KB 138.9KB +46.0B
visTypeTimeseries 511.7KB 511.8KB +46.0B
total +138.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 436 442 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 512 518 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

jeramysoucy
jeramysoucy approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson watson merged commit 0d2e815 into elastic:main Dec 22, 2022
@kibanamachine kibanamachine mentioned this pull request Dec 22, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 22, 2022
[@kbn/handlebars] Refactor internal context handling (elastic#148029)
6d8cce9 
(cherry picked from commit 0d2e815)
@watson watson deleted the handlebars-refactor-contexts branch December 22, 2022 21:53
kibanamachine added a commit that referenced this pull request Dec 22, 2022
@kibanamachine
[8.6] [@kbn/handlebars] Refactor internal context handling (#148029) (#…
fe42d07 
…148035)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[@kbn/handlebars] Refactor internal context handling
(#148029)](#148029)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thomas
Watson","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T21:23:43Z","message":"[@kbn/handlebars]
Refactor internal context handling
(#148029)","sha":"0d2e8156bf8c0e5d38a40fb02f94662348e9377a","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.7.0"],"number":148029,"url":"https://github.com/elastic/kibana/pull/148029","mergeCommit":{"message":"[@kbn/handlebars]
Refactor internal context handling
(#148029)","sha":"0d2e8156bf8c0e5d38a40fb02f94662348e9377a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148029","number":148029,"mergeCommit":{"message":"[@kbn/handlebars]
Refactor internal context handling
(#148029)","sha":"0d2e8156bf8c0e5d38a40fb02f94662348e9377a"}}]}]
BACKPORT-->

Co-authored-by: Thomas Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

Assignees

@watson watson

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watson @kibana-ci @kibanamachine @jeramysoucy