Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing upgrade dashboard smoke test render error #147037

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Fixing upgrade dashboard smoke test render error #147037

merged 2 commits into from
Dec 5, 2022

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Dec 5, 2022 •
edited by kibanamachine
Loading

Resetting the timepicker to one year to fix the error below:

Upgrade dashboard smoke test is failing on "should render visualizations"

upgrade
02:47:39        upgrade dashboard smoke tests
02:47:39          space: default
02:47:39            should render visualizations:
02:47:39 
02:47:39       retry.try timeout: Error: expected 0 to be above 49
02:47:39      at Assertion.assert (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:100:11)
02:47:40      at Assertion.greaterThan.Assertion.above (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:317:8)
02:47:40      at Function.above (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:531:15)
02:47:40      at /var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:235:29
02:47:40      at runMicrotasks (<anonymous>)
02:47:40      at processTicksAndRejections (node:internal/process/task_queues:96:5)
02:47:40      at runAttempt (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:29:15)
02:47:40      at retryForSuccess (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:63:21)
02:47:40      at RetryService.try (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40      at DashboardExpectService.savedSearchRowCount (/var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:229:5)
02:47:40      at Context.<anonymous> (/var/lib/jenkins/workspace/kibana/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40      at Object.apply (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40    Error: retry.try timeout: Error: expected 0 to be above 49
02:47:40        at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
02:47:40        at Assertion.greaterThan.Assertion.above (node_modules/@kbn/expect/expect.js:317:8)
02:47:40        at Function.above (node_modules/@kbn/expect/expect.js:531:15)
02:47:40        at /var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:235:29
02:47:40        at runMicrotasks (<anonymous>)
02:47:40        at processTicksAndRejections (node:internal/process/task_queues:96:5)
02:47:40        at runAttempt (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:29:15)
02:47:40        at retryForSuccess (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:63:21)
02:47:40        at RetryService.try (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40        at DashboardExpectService.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:229:5)
02:47:40        at Context.<anonymous> (x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40        at /var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:19:9
02:47:40        at retryForSuccess (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:55:13)
02:47:40        at RetryService.try (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40        at DashboardExpectService.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:229:5)
02:47:40        at Context.<anonymous> (x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40  
02:47:40  
02:47:40 2)    upgrade
02:47:40        upgrade dashboard smoke tests
02:47:40          space: automation
02:47:40            should render visualizations:
02:47:40 
02:47:40       retry.try timeout: Error: expected 0 to be above 49
02:47:40      at Assertion.assert (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:100:11)
02:47:40      at Assertion.greaterThan.Assertion.above (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:317:8)
02:47:40      at Function.above (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/expect/expect.js:531:15)
02:47:40      at /var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:235:29
02:47:40      at runMicrotasks (<anonymous>)
02:47:40      at processTicksAndRejections (node:internal/process/task_queues:96:5)
02:47:40      at runAttempt (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:29:15)
02:47:40      at retryForSuccess (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:63:21)
02:47:40      at RetryService.try (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40      at DashboardExpectService.savedSearchRowCount (/var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:229:5)
02:47:40      at Context.<anonymous> (/var/lib/jenkins/workspace/kibana/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40      at Object.apply (/var/lib/jenkins/workspace/kibana/node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40    Error: retry.try timeout: Error: expected 0 to be above 49
02:47:40        at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
02:47:40        at Assertion.greaterThan.Assertion.above (node_modules/@kbn/expect/expect.js:317:8)
02:47:40        at Function.above (node_modules/@kbn/expect/expect.js:531:15)
02:47:40        at /var/lib/jenkins/workspace/kibana/test/functional/services/dashboard/expectations.ts:235:29
02:47:40        at runMicrotasks (<anonymous>)
02:47:40        at processTicksAndRejections (node:internal/process/task_queues:96:5)
02:47:40        at runAttempt (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:29:15)
02:47:40        at retryForSuccess (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:63:21)
02:47:40        at RetryService.try (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40        at DashboardExpectService.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:229:5)
02:47:40        at Context.<anonymous> (x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40        at /var/lib/jenkins/workspace/kibana/node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:19:9
02:47:40        at retryForSuccess (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:55:13)
02:47:40        at RetryService.try (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:35:12)
02:47:40        at DashboardExpectService.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:229:5)
02:47:40        at Context.<anonymous> (x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts:56:11)
02:47:40        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
02:47:40

@bhavyarm bhavyarm self-assigned this Dec 5, 2022
@bhavyarm bhavyarm added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Dec 5, 2022
@bhavyarm bhavyarm added the Team:QA Team label for QA Team label Dec 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm requested a review from marius-dr December 5, 2022 18:40
@bhavyarm bhavyarm added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Dec 5, 2022
marius-dr
marius-dr approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bhavyarm bhavyarm added the v8.6.0 label Dec 5, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit a433b64 into elastic:main Dec 5, 2022
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Dec 5, 2022

Please note these tests don't run in CI. Thanks!

@kibanamachine kibanamachine mentioned this pull request Dec 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2022
@bhavyarm
Fixing upgrade dashboard smoke test render error (elastic#147037)
4338344 
(cherry picked from commit a433b64)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2022
@kibanamachine @bhavyarm
[8.6] Fixing upgrade dashboard smoke test render error (#147037) (#14…
e13d14d 
…7047)

# Backport

This will backport the following commits from `main` to `8.6`:
- [Fixing upgrade dashboard smoke test render error
(#147037)](#147037)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bhavya
RM","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-05T19:55:34Z","message":"Fixing
upgrade dashboard smoke test render error
(#147037)","sha":"a433b647e4b86b116d464b27696ca434ddcee967","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","release_note:skip","backport:prev-minor","v8.6.0","v8.7.0"],"number":147037,"url":"https://github.com/elastic/kibana/pull/147037","mergeCommit":{"message":"Fixing
upgrade dashboard smoke test render error
(#147037)","sha":"a433b647e4b86b116d464b27696ca434ddcee967"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147037","number":147037,"mergeCommit":{"message":"Fixing
upgrade dashboard smoke test render error
(#147037)","sha":"a433b647e4b86b116d464b27696ca434ddcee967"}}]}]
BACKPORT-->

Co-authored-by: Bhavya RM <[email protected]>
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Dec 6, 2022
@bhavyarm
Fixing upgrade dashboard smoke test render error (elastic#147037)
40bb2c0
@bhavyarm bhavyarm mentioned this pull request Dec 6, 2022
Merged
bhavyarm added a commit that referenced this pull request Dec 6, 2022
@bhavyarm
Backport Fixing upgrade dashboard smoke test render error #147037 to …
02aae9f 
…8.5 (#147133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @elasticmachine @kibana-ci @kibanamachine @marius-dr