Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Set unified search bar displayStyle to 'inPage' on hosts page #146671

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[Infrastructure UI] Set unified search bar displayStyle to 'inPage' on hosts page #146671

merged 2 commits into from
Nov 30, 2022

Conversation

jennypavlova
Copy link
Member

Closes: #146670

Summary

This PR fixes the unified search bar size on the host view page.

@jennypavlova jennypavlova added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.7.0 labels Nov 30, 2022
@jennypavlova jennypavlova self-assigned this Nov 30, 2022
@jennypavlova jennypavlova requested a review from a team as a code owner November 30, 2022 10:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

crespocarlos
crespocarlos approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Loved the attention to details.

image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.1MB 1.1MB +22.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova jennypavlova merged commit 93d5d38 into elastic:main Nov 30, 2022
@jennypavlova jennypavlova deleted the 146670-infrastructure-ui-host-view-unified-search-bar-has-wrong-size branch November 30, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Host View: Unified search bar has wrong size
4 participants
@jennypavlova @elasticmachine @kibana-ci @crespocarlos