[Security Solution][Alerts] Don't use maxSignals for topHits agg size #146564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmain
added
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 30, 2022
…elastic#146564) ## Summary Addresses elastic#146494 We only need the first document from the bucket to create the alert, not `maxSignals` documents. If `maxSignals` was greater than 100, this caused an error in the search. (cherry picked from commit d659ee6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 30, 2022
…g size (#146564) (#146712) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution][Alerts] Don't use maxSignals for topHits agg size (#146564)](#146564) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-30T15:50:16Z","message":"[Security Solution][Alerts] Don't use maxSignals for topHits agg size (#146564)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/146494\r\n\r\nWe only need the first document from the bucket to create the alert, not\r\n`maxSignals` documents. If `maxSignals` was greater than 100, this\r\ncaused an error in the search.","sha":"d659ee6f2eb04e81b240db137996aa2a4c4378b1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Detection Alerts","v8.6.0","v8.7.0"],"number":146564,"url":"https://github.com/elastic/kibana/pull/146564","mergeCommit":{"message":"[Security Solution][Alerts] Don't use maxSignals for topHits agg size (#146564)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/146494\r\n\r\nWe only need the first document from the bucket to create the alert, not\r\n`maxSignals` documents. If `maxSignals` was greater than 100, this\r\ncaused an error in the search.","sha":"d659ee6f2eb04e81b240db137996aa2a4c4378b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146564","number":146564,"mergeCommit":{"message":"[Security Solution][Alerts] Don't use maxSignals for topHits agg size (#146564)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/146494\r\n\r\nWe only need the first document from the bucket to create the alert, not\r\n`maxSignals` documents. If `maxSignals` was greater than 100, this\r\ncaused an error in the search.","sha":"d659ee6f2eb04e81b240db137996aa2a4c4378b1"}}]}] BACKPORT--> Co-authored-by: Marshall Main <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #146494
We only need the first document from the bucket to create the alert, not
maxSignalsdocuments. IfmaxSignalswas greater than 100, this caused an error in the search.