[APM] Service map simplifications #146536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
commented
Nov 29, 2022
| } | ||
|
|
||
| async function getConnectionData({ | ||
| config, | ||
| apmEventClient, | ||
| serviceNames, | ||
| serviceName, |
There was a problem hiding this comment.
serviceNames is always a single value at most so there's no reason for it to be an array.
sorenlouv
commented
Nov 29, 2022
| environment, | ||
| start, | ||
| end, | ||
| serviceGroup, | ||
| serviceGroupKuery, |
There was a problem hiding this comment.
We only use the kuery from the service group. Changing this to be an optional string is slightly simpler (and more clear).
sorenlouv
commented
Nov 29, 2022
| * 2.0. | ||
| */ | ||
|
|
||
| import { |
There was a problem hiding this comment.
Nothing here changes. This file was just extracted from get_service_map.ts.
sorenlouv
force-pushed
the
service-map-simplifications
branch
from
4fba9b5 to
cdd44df
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
sorenlouv
added
v8.7.0
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should make it simpler to add the search bar to the service map.