[ML] Add API tests for index exists endpoint #146400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
12 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2022
## Summary Adds tests to check the response of the index exists endpoint: ``` /api/ml/index_exists ``` Also fixed the behavior of the endpoint when passed an index with a wilcard expression so that it no longer returns `true` if an index does not exist matching the expression by adding `allow_no_indices: false` to the query parameters. Part of elastic#142456 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 4294e3b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[ML] Add API tests for index exists endpoint (#146400)](#146400) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pete Harverson","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-07T13:12:17Z","message":"[ML] Add API tests for index exists endpoint (#146400)\n\n## Summary\r\n\r\nAdds tests to check the response of the index exists endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed the behavior of the endpoint when passed an index with a\r\nwilcard expression so that it no longer returns `true` if an index does\r\nnot exist matching the expression by adding `allow_no_indices: false` to\r\nthe query parameters.\r\n\r\nPart of https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review",":ml","release_note:skip","test-api-integration","v8.6.0","v8.7.0"],"number":146400,"url":"https://github.com/elastic/kibana/pull/146400","mergeCommit":{"message":"[ML] Add API tests for index exists endpoint (#146400)\n\n## Summary\r\n\r\nAdds tests to check the response of the index exists endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed the behavior of the endpoint when passed an index with a\r\nwilcard expression so that it no longer returns `true` if an index does\r\nnot exist matching the expression by adding `allow_no_indices: false` to\r\nthe query parameters.\r\n\r\nPart of https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146400","number":146400,"mergeCommit":{"message":"[ML] Add API tests for index exists endpoint (#146400)\n\n## Summary\r\n\r\nAdds tests to check the response of the index exists endpoint:\r\n\r\n```\r\n/api/ml/index_exists\r\n```\r\n\r\nAlso fixed the behavior of the endpoint when passed an index with a\r\nwilcard expression so that it no longer returns `true` if an index does\r\nnot exist matching the expression by adding `allow_no_indices: false` to\r\nthe query parameters.\r\n\r\nPart of https://github.com/elastic/kibana/issues/142456\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"4294e3b17f559a0073f5453a47df7e9dc83c58ba"}}]}] BACKPORT--> Co-authored-by: Pete Harverson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests to check the response of the index exists endpoint:
Also fixed the behavior of the endpoint when passed an index with a wilcard expression so that it no longer returns
trueif an index does not exist matching the expression by addingallow_no_indices: falseto the query parameters.Part of #142456
Checklist