[ML] Explain Log Rate Spikes: Additional API integration tests #146113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
v8.6.0
v8.7.0
:ml
Feature:ML/AIOps
|
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1590 🟧 49/50 passed with one unrelated failure (we can only run all x-pack API integration at once not just the aiops ones) |
12 tasks
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
the
release_note:skip
|
Code LGTM but not sure if the flaky test runner failure needs to be addressed |
|
I kicked off another flaky test runner, the failed test is unrelated to this PR though, unfortunately AFAIK we can only run all x-pack API integration tests at once not just the aiops ones. |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
|
✅ In the latest flaky test runner all tests passed: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1595 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 24, 2022
…ic#146113) Additional API integration tests. - The test data was moved to its own file `test_data.ts` and types for its structure defined in `types.ts` to be in line with the structure used for functional tests. - The file that runs the test was extended so it can run an array of test data definitions. - The datasets used in the funcional tests (`ecommerce` with some additional documents added to create a significant spike and the computationally generated spike data set to create distinct groups) were moved to a service `ExplainLogRateSpikesDataGenerator` so they can be generated and used across functional and API integration tests. - The computationally generated spike data set `artificial_logs_with_spike` is now also used for API integration tests. - Additional assertions have been added to check the grouping result. `ecommerce` does not return any groups whereas `artificial_logs_with_spike` does. - The functional tests code is now consolidated and one test file is able to run multiple test data definitions too. (cherry picked from commit 5481f07)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2022
…146113) (#146263) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: Additional API integration tests (#146113)](#146113) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-24T09:41:11Z","message":"[ML] Explain Log Rate Spikes: Additional API integration tests (#146113)\n\nAdditional API integration tests.\r\n\r\n- The test data was moved to its own file `test_data.ts` and types for\r\nits structure defined in `types.ts` to be in line with the structure\r\nused for functional tests.\r\n- The file that runs the test was extended so it can run an array of\r\ntest data definitions.\r\n- The datasets used in the funcional tests (`ecommerce` with some\r\nadditional documents added to create a significant spike and the\r\ncomputationally generated spike data set to create distinct groups) were\r\nmoved to a service `ExplainLogRateSpikesDataGenerator` so they can be\r\ngenerated and used across functional and API integration tests.\r\n- The computationally generated spike data set\r\n`artificial_logs_with_spike` is now also used for API integration tests.\r\n- Additional assertions have been added to check the grouping result.\r\n`ecommerce` does not return any groups whereas\r\n`artificial_logs_with_spike` does.\r\n- The functional tests code is now consolidated and one test file is\r\nable to run multiple test data definitions too.","sha":"5481f07f79e6923a982ae5ce42af051630b10646","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":146113,"url":"https://github.com/elastic/kibana/pull/146113","mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Additional API integration tests (#146113)\n\nAdditional API integration tests.\r\n\r\n- The test data was moved to its own file `test_data.ts` and types for\r\nits structure defined in `types.ts` to be in line with the structure\r\nused for functional tests.\r\n- The file that runs the test was extended so it can run an array of\r\ntest data definitions.\r\n- The datasets used in the funcional tests (`ecommerce` with some\r\nadditional documents added to create a significant spike and the\r\ncomputationally generated spike data set to create distinct groups) were\r\nmoved to a service `ExplainLogRateSpikesDataGenerator` so they can be\r\ngenerated and used across functional and API integration tests.\r\n- The computationally generated spike data set\r\n`artificial_logs_with_spike` is now also used for API integration tests.\r\n- Additional assertions have been added to check the grouping result.\r\n`ecommerce` does not return any groups whereas\r\n`artificial_logs_with_spike` does.\r\n- The functional tests code is now consolidated and one test file is\r\nable to run multiple test data definitions too.","sha":"5481f07f79e6923a982ae5ce42af051630b10646"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146113","number":146113,"mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Additional API integration tests (#146113)\n\nAdditional API integration tests.\r\n\r\n- The test data was moved to its own file `test_data.ts` and types for\r\nits structure defined in `types.ts` to be in line with the structure\r\nused for functional tests.\r\n- The file that runs the test was extended so it can run an array of\r\ntest data definitions.\r\n- The datasets used in the funcional tests (`ecommerce` with some\r\nadditional documents added to create a significant spike and the\r\ncomputationally generated spike data set to create distinct groups) were\r\nmoved to a service `ExplainLogRateSpikesDataGenerator` so they can be\r\ngenerated and used across functional and API integration tests.\r\n- The computationally generated spike data set\r\n`artificial_logs_with_spike` is now also used for API integration tests.\r\n- Additional assertions have been added to check the grouping result.\r\n`ecommerce` does not return any groups whereas\r\n`artificial_logs_with_spike` does.\r\n- The functional tests code is now consolidated and one test file is\r\nable to run multiple test data definitions too.","sha":"5481f07f79e6923a982ae5ce42af051630b10646"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #142456.
Additional API integration tests.
test_data.tsand types for its structure defined intypes.tsto be in line with the structure used for functional tests.ecommercewith some additional documents added to create a significant spike and the computationally generated spike data set to create distinct groups) were moved to a serviceExplainLogRateSpikesDataGeneratorso they can be generated and used across functional and API integration tests.artificial_logs_with_spikeis now also used for API integration tests.ecommercedoes not return any groups whereasartificial_logs_with_spikedoes.Checklist