Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add accessibility test for population and advanced job wizards #146052

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Nov 22, 2022

Summary

Part of #142456. This PR adds accessibility test for population and advanced job wizards

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 force-pushed the ml-accessibility-tests branch from c707f6f to 8b2c8aa Compare November 22, 2022 21:02
@qn895 qn895 self-assigned this Nov 22, 2022
@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Nov 22, 2022
@qn895 qn895 requested a review from pheyos November 22, 2022 22:27
@qn895 qn895 marked this pull request as ready for review November 22, 2022 22:27
@qn895 qn895 requested a review from a team as a code owner November 22, 2022 22:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Nov 23, 2022

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) November 23, 2022 15:50
@qn895 qn895 merged commit 83bf248 into elastic:main Nov 23, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 23, 2022
…ards (#146052) (#146191)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Add accessibility test for population and advanced job wizards
(#146052)](#146052)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quynh Nguyen
(Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-23T16:48:38Z","message":"[ML]
Add accessibility test for population and advanced job wizards
(#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v8.6.0","v8.7.0"],"number":146052,"url":"https://github.com/elastic/kibana/pull/146052","mergeCommit":{"message":"[ML]
Add accessibility test for population and advanced job wizards
(#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146052","number":146052,"mergeCommit":{"message":"[ML]
Add accessibility test for population and advanced job wizards
(#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d"}}]}]
BACKPORT-->

Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants