-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add accessibility test for population and advanced job wizards #146052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
force-pushed
the
ml-accessibility-tests
branch
from
November 22, 2022 21:02
c707f6f
to
8b2c8aa
Compare
qn895
added
:ml
release_note:skip
Skip the PR/issue when compiling release notes
v8.6.0
labels
Nov 22, 2022
Pinging @elastic/ml-ui (:ml) |
26 tasks
peteharverson
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12 tasks
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @qn895 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2022
…lastic#146052) (cherry picked from commit 83bf248)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2022
…ards (#146052) (#146191) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Add accessibility test for population and advanced job wizards (#146052)](#146052) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-23T16:48:38Z","message":"[ML] Add accessibility test for population and advanced job wizards (#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v8.6.0","v8.7.0"],"number":146052,"url":"https://github.com/elastic/kibana/pull/146052","mergeCommit":{"message":"[ML] Add accessibility test for population and advanced job wizards (#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146052","number":146052,"mergeCommit":{"message":"[ML] Add accessibility test for population and advanced job wizards (#146052)","sha":"83bf248540e0f61a66973b8b5dcc538f2dc0554d"}}]}] BACKPORT--> Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #142456. This PR adds accessibility test for population and advanced job wizards
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers