[ML] Explain Log Rate Spikes: Additional functional tests with artificial logs dataset #145763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
walterra
force-pushed
the
ml-aiops-dataset-2
branch
from
4972b99 to
9a55633
Compare
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Nov 21, 2022
|
Running flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1584 ✅ 50 runs passed! |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2022
…cial logs dataset (elastic#145763) Additional functional tests with artificial logs dataset. This generates an artificial logs dataset with the purpose of asserting the case where grouping needs to identify 2 non-overlapping groups. The primary use case of the test is to track possible regressions related to when trying to improve `frequent_items` aggregation settings and the custom grouping code. (cherry picked from commit c45f556)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2022
…artificial logs dataset (#145763) (#146038) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: Additional functional tests with artificial logs dataset (#145763)](#145763) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-22T17:28:54Z","message":"[ML] Explain Log Rate Spikes: Additional functional tests with artificial logs dataset (#145763)\n\nAdditional functional tests with artificial logs dataset.\r\n\r\nThis generates an artificial logs dataset with the purpose of asserting\r\nthe case where grouping needs to identify 2 non-overlapping groups. The\r\nprimary use case of the test is to track possible regressions related to\r\nwhen trying to improve `frequent_items` aggregation settings and the\r\ncustom grouping code.","sha":"c45f55660584381d385e11817d4285e3e24eb546","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":145763,"url":"https://github.com/elastic/kibana/pull/145763","mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Additional functional tests with artificial logs dataset (#145763)\n\nAdditional functional tests with artificial logs dataset.\r\n\r\nThis generates an artificial logs dataset with the purpose of asserting\r\nthe case where grouping needs to identify 2 non-overlapping groups. The\r\nprimary use case of the test is to track possible regressions related to\r\nwhen trying to improve `frequent_items` aggregation settings and the\r\ncustom grouping code.","sha":"c45f55660584381d385e11817d4285e3e24eb546"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145763","number":145763,"mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Additional functional tests with artificial logs dataset (#145763)\n\nAdditional functional tests with artificial logs dataset.\r\n\r\nThis generates an artificial logs dataset with the purpose of asserting\r\nthe case where grouping needs to identify 2 non-overlapping groups. The\r\nprimary use case of the test is to track possible regressions related to\r\nwhen trying to improve `frequent_items` aggregation settings and the\r\ncustom grouping code.","sha":"c45f55660584381d385e11817d4285e3e24eb546"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #145699.
Part of #142456.
Additional functional tests with artificial logs dataset.
This generates an artificial logs dataset with the purpose of asserting the case where grouping needs to identify 2 non-overlapping groups. The primary use case of the test is to track possible regressions related to when trying to improve
frequent_itemsaggregation settings and the custom grouping code.I plan to use the same approach for additional tests on the API integration side. Once I do this follow up I'll look into how some code that was duplicated for this PR can be consolidated.
Checklist