From 16051041854a8e0effea91479a8f61e94355733b Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Thu, 8 Sep 2022 15:27:40 -0400 Subject: [PATCH 1/6] Removed comment of the issue that was referenced for the skip. But the tests were already skipped. --- .../test/functional/apps/home/feature_controls/home_security.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/x-pack/test/functional/apps/home/feature_controls/home_security.ts b/x-pack/test/functional/apps/home/feature_controls/home_security.ts index a48bc7651a1ed..831f0475c2c11 100644 --- a/x-pack/test/functional/apps/home/feature_controls/home_security.ts +++ b/x-pack/test/functional/apps/home/feature_controls/home_security.ts @@ -35,7 +35,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await esArchiver.unload('x-pack/test/functional/es_archives/logstash_functional'); }); - // https://github.com/elastic/kibana/issues/132628 describe('global all privileges', () => { before(async () => { await security.role.create('global_all_role', { From fd1727b2d1e312cb1e2802176563ebd29b2c4ebc Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Fri, 28 Oct 2022 05:52:53 -0400 Subject: [PATCH 2/6] Added a describe block for the tests that involve space b. There is an accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped. --- x-pack/test/accessibility/apps/spaces.ts | 48 ++++++++++++------------ 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/x-pack/test/accessibility/apps/spaces.ts b/x-pack/test/accessibility/apps/spaces.ts index 482429071e3bb..2a4923a15d08c 100644 --- a/x-pack/test/accessibility/apps/spaces.ts +++ b/x-pack/test/accessibility/apps/spaces.ts @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const toasts = getService('toasts'); const kibanaServer = getService('kibanaServer'); - // FLAKY: https://github.com/elastic/kibana/issues/137136 - describe.skip('Kibana Spaces Accessibility', () => { + describe('Kibana Spaces Accessibility', () => { before(async () => { await kibanaServer.savedObjects.cleanStandardList(); await PageObjects.common.navigateToApp('home'); @@ -86,29 +85,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); // creating space b and making it the current space so space selector page gets displayed when space b gets deleted - // FLAKY: https://github.com/elastic/kibana/issues/135341 - it.skip('a11y test for delete space button', async () => { - await PageObjects.spaceSelector.clickCreateSpace(); - await PageObjects.spaceSelector.clickEnterSpaceName(); - await PageObjects.spaceSelector.addSpaceName('space_b'); - await PageObjects.spaceSelector.clickSaveSpaceCreation(); - await PageObjects.common.navigateToApp('home'); - await PageObjects.spaceSelector.openSpacesNav(); - await PageObjects.spaceSelector.clickSpaceAvatar('space_b'); - await PageObjects.header.waitUntilLoadingHasFinished(); - await PageObjects.spaceSelector.openSpacesNav(); - await PageObjects.spaceSelector.clickManageSpaces(); - await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b'); - await a11y.testAppSnapshot(); - }); - - // test starts with deleting space b so we can get the space selection page instead of logging out in the test - it('a11y test for space selection page', async () => { - await PageObjects.spaceSelector.confirmDeletingSpace(); - await retry.try(async () => { + // Skipped due to an a11y violation + // https://github.com/elastic/kibana/issues/144155 + describe.skip('Create Space B and Verify', async () => { + it('a11y test for delete space button', async () => { + await PageObjects.spaceSelector.clickCreateSpace(); + await PageObjects.spaceSelector.clickEnterSpaceName(); + await PageObjects.spaceSelector.addSpaceName('space_b'); + await PageObjects.spaceSelector.clickSaveSpaceCreation(); + await PageObjects.common.navigateToApp('home'); + await PageObjects.spaceSelector.openSpacesNav(); + await PageObjects.spaceSelector.clickSpaceAvatar('space_b'); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.spaceSelector.openSpacesNav(); + await PageObjects.spaceSelector.clickManageSpaces(); + await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b'); await a11y.testAppSnapshot(); }); - await PageObjects.spaceSelector.clickSpaceCard('default'); + + // test starts with deleting space b so we can get the space selection page instead of logging out in the test + it('a11y test for space selection page', async () => { + await PageObjects.spaceSelector.confirmDeletingSpace(); + await retry.try(async () => { + await a11y.testAppSnapshot(); + }); + await PageObjects.spaceSelector.clickSpaceCard('default'); + }); }); }); } From 12b08b72f61483d8728eee533840871da8338e22 Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Wed, 2 Nov 2022 14:47:55 -0400 Subject: [PATCH 3/6] Added CCS Test for integration test. --- .../apps/ccs/ccs_console.js | 42 +++++++++++++++++++ .../apps/ccs/index.js | 1 + 2 files changed, 43 insertions(+) create mode 100644 x-pack/test/stack_functional_integration/apps/ccs/ccs_console.js diff --git a/x-pack/test/stack_functional_integration/apps/ccs/ccs_console.js b/x-pack/test/stack_functional_integration/apps/ccs/ccs_console.js new file mode 100644 index 0000000000000..77cab900c30be --- /dev/null +++ b/x-pack/test/stack_functional_integration/apps/ccs/ccs_console.js @@ -0,0 +1,42 @@ +/* + * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one + * or more contributor license agreements. Licensed under the Elastic License + * 2.0 and the Server Side Public License, v 1; you may not use this file except + * in compliance with, at your election, the Elastic License 2.0 or the Server + * Side Public License, v 1. + */ + +import expect from '@kbn/expect'; + +export default function ({ getService, getPageObjects }) { + const retry = getService('retry'); + const log = getService('log'); + const PageObjects = getPageObjects(['common', 'console']); + + describe('Integration Tests - Console App CCS', function describeIndexTests() { + this.tags('includeFirefox'); + before(async () => { + log.debug('navigateTo console'); + await PageObjects.common.navigateToApp('console'); + await retry.try(async () => { + await PageObjects.console.collapseHelp(); + }); + }); + + describe('Perform CCS Search in Console', () => { + before(async () => { + await PageObjects.console.clearTextArea(); + }); + it('it should be able to access remote data', async () => { + await PageObjects.console.enterRequest( + '\nGET data:makelogs工程-*/_search\n {\n "query": {\n "bool": {\n "must": [\n {"match": {"extension" : "jpg"' + ); + await PageObjects.console.clickPlay(); + await retry.try(async () => { + const actualResponse = await PageObjects.console.getResponse(); + expect(actualResponse).to.contain('"_index": "data:makelogs工程-0"'); + }); + }); + }); + }); +} diff --git a/x-pack/test/stack_functional_integration/apps/ccs/index.js b/x-pack/test/stack_functional_integration/apps/ccs/index.js index ac82ca0dfda65..2f24a0e31d7dc 100644 --- a/x-pack/test/stack_functional_integration/apps/ccs/index.js +++ b/x-pack/test/stack_functional_integration/apps/ccs/index.js @@ -8,5 +8,6 @@ export default function ({ loadTestFile }) { describe('ccs test', function () { loadTestFile(require.resolve('./ccs_discover')); + loadTestFile(require.resolve('./ccs_console')); }); } From be3a5c0ea7a702c80a9999941acd3ba4265d77e9 Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Tue, 15 Nov 2022 23:50:11 -0500 Subject: [PATCH 4/6] Removed validation rule that did not allow spaces. --- .../configuration_form_schema.tsx | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx index d8e3e8d5ae7c2..f8f642f02b5e5 100644 --- a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx +++ b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx @@ -168,20 +168,6 @@ export const configurationFormSchema: FormSchema = { ), type: FIELD_TYPES.COMBO_BOX, defaultValue: ['strict_date_optional_time', 'yyyy/MM/dd HH:mm:ss Z||yyyy/MM/dd Z'], - validations: [ - { - validator: containsCharsField({ - message: i18n.translate( - 'xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage', - { - defaultMessage: 'Spaces are not allowed.', - } - ), - chars: ' ', - }), - type: VALIDATION_TYPES.ARRAY_ITEM, - }, - ], }, }, _routing: { From 785c13199021c2bb28f1ad05d2dd9abdc26c2ae0 Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Wed, 16 Nov 2022 00:02:27 -0500 Subject: [PATCH 5/6] Removed unused variables. --- .../configuration_form/configuration_form_schema.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx index f8f642f02b5e5..843c5aed6ece5 100644 --- a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx +++ b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/configuration_form_schema.tsx @@ -12,10 +12,10 @@ import { FormattedMessage } from '@kbn/i18n-react'; import { EuiLink, EuiCode } from '@elastic/eui'; import { documentationService } from '../../../../services/documentation'; -import { FormSchema, FIELD_TYPES, VALIDATION_TYPES, fieldValidators } from '../../shared_imports'; +import { FormSchema, FIELD_TYPES, fieldValidators } from '../../shared_imports'; import { ComboBoxOption } from '../../types'; -const { containsCharsField, isJsonField } = fieldValidators; +const { isJsonField } = fieldValidators; const fieldPathComboBoxConfig = { helpText: i18n.translate( From 111e9bdab906a36ee81c66ea7bb950b3b9b310d7 Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Wed, 16 Nov 2022 00:17:08 -0500 Subject: [PATCH 6/6] Removed validation error message translations since the validation message no longer exists for this component. --- x-pack/plugins/translations/translations/fr-FR.json | 1 - x-pack/plugins/translations/translations/ja-JP.json | 1 - x-pack/plugins/translations/translations/zh-CN.json | 1 - 3 files changed, 3 deletions(-) diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index 674f0976028a3..aab3bbedd3352 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -14401,7 +14401,6 @@ "xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "Mapper les chaînes de dates en tant que dates", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "En savoir plus.", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "Formats de dates", - "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "Les espaces ne sont pas autorisés.", "xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "Par défaut, les champs non mappés sont ignorés silencieusement lorsque le mapping dynamique est désactivé. Vous pouvez aussi choisir de lever une exception lorsqu'un document contient un champ non mappé.", "xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "Activer le mapping dynamique", "xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "Exclure les champs", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index f1c6fb85d2648..8611bfc352a7b 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -14387,7 +14387,6 @@ "xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "日付文字列の日付としてのマッピング", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "詳細情報", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "日付フォーマット", - "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "スペースは使用できません。", "xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "デフォルトとしては、動的マッピングが無効の場合、マップされていないフィールドは通知なし無視されます。オプションとして、ドキュメントがマッピングされていないフィールドを含む場合、例外を選択とすることも可能です。", "xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "動的マッピングの有効化", "xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "フィールドの除外", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index d29e13df48fc6..189b2b404973b 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -14407,7 +14407,6 @@ "xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "将日期字符串映射为日期", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "了解详情。", "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "日期格式", - "xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "不允许使用空格。", "xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "默认情况下，禁用动态映射时，将会忽略未映射字段。文档包含未映射字段时，您可以根据需要引发异常。", "xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "启用动态映射", "xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "排除字段",