Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared UX] Migrate router to shared ux from kibana react #137489

Closed
wants to merge 3 commits into from

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Jul 28, 2022

Summary

Building from discussion in #132629, this PR aims to refactor the kibana router.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rshen91 rshen91 changed the title [Shared_ux] Migrate router to shared ux from kibana react [Shared UX] Migrate router to shared ux from kibana react Jul 28, 2022
@rshen91
Copy link
Contributor Author

rshen91 commented Aug 10, 2022

issues with git versioning opening new draft PR with changes

@rshen91 rshen91 closed this Aug 10, 2022
@rshen91 rshen91 deleted the router-migration branch August 10, 2022 16:40
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 10, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • 💚 Build #63785 succeeded c4844a9ce06370384c3d173737bf645e2ba840b6
  • 💔 Build #63347 failed 836831ceffc50c387848bcd78431d67b26a552a8
  • 💔 Build #63210 failed 8231364cdc612a5b0a9bb6f778b5d8cfe0624fdb
  • 💔 Build #63034 failed d58881eb08fc56f4508767f74bc751fa4b2373f2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants