Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Fix edit component template without fleet datastream #136686

Conversation

nchaulet
Copy link
Member

Summary

Fix a bug introduced in #135845 where we show a 0 in the middle of the UI if there is no Fleet datastream

Before

Screen Shot 2022-07-19 at 4 58 50 PM

After

Screen Shot 2022-07-19 at 4 59 52 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jul 19, 2022
@nchaulet nchaulet requested a review from sabarasaba July 19, 2022 21:03
@nchaulet nchaulet requested a review from a team as a code owner July 19, 2022 21:03
@nchaulet nchaulet self-assigned this Jul 19, 2022
@nchaulet nchaulet force-pushed the fix-edit-component-template-without-fleet-datastream branch from 3e6c412 to b1ff0b3 Compare July 19, 2022 21:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 520.6KB 520.6KB +10.0B

History

  • 💔 Build #58907 failed 3e6c4120eaeb39f3fdf91a8ce5274be26210c97a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit e671125 into elastic:main Jul 20, 2022
@nchaulet nchaulet deleted the fix-edit-component-template-without-fleet-datastream branch July 20, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants