Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Canvas] Added await isEditable handling. #136607

Merged
merged 2 commits into from
Jul 20, 2022
Merged

[Dashboard] [Canvas] Added await isEditable handling. #136607

merged 2 commits into from
Jul 20, 2022

Conversation

Kuznietsov
Copy link
Contributor

Summary

Closes: #121003

@Kuznietsov Kuznietsov added Feature:Dashboard Dashboard related features WIP Work in progress Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. backport:skip This commit does not require backporting v8.4.0 labels Jul 19, 2022
@Kuznietsov Kuznietsov requested a review from alexwizp July 19, 2022 09:23
@Kuznietsov Kuznietsov self-assigned this Jul 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +228.0B
dashboard 380.5KB 380.7KB +212.0B
total +440.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov requested a review from ThomThomson July 19, 2022 12:13
@Kuznietsov Kuznietsov marked this pull request as ready for review July 19, 2022 12:13
@Kuznietsov Kuznietsov requested a review from a team as a code owner July 19, 2022 12:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter self-requested a review July 19, 2022 19:15
@Heenawter Heenawter changed the title [Dashboard] Added await isEditable handling. [Dashboard] [Canvas] Added await isEditable handling. Jul 19, 2022
Heenawter
Heenawter approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + tested locally via, for both Dashboard and Canvas,

  1. Created a custom space without access to Maps or Machine Learning
  2. Throttled the network connection
  3. Created a new dashboard/workpad
  4. Ensured that, when clicking the "Select type" button, neither Maps nor Machine Learning visualizations showed up in the dropdown

Everything worked great 👍

@Kuznietsov Kuznietsov removed the WIP Work in progress label Jul 20, 2022
@Kuznietsov Kuznietsov merged commit 1055b7e into elastic:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@ThomThomson ThomThomson Awaiting requested review from ThomThomson

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Canvas Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard][Canvas] Await IsEditable
4 participants
@Kuznietsov @kibana-ci @elasticmachine @Heenawter