-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix _source fields of objects formatting #136473
[Discover] Fix _source fields of objects formatting #136473
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @dimaanj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimaanj thx a lot for fixing this, 2 flies (issues) with 1 stone(PR) 👍 , tested locally with the demo data, 2 issues fixed, works as expected
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
- when fetching _source nested objects like obj.rootKey.subkey1, object.rootKey.subkey2 were not flattened correctly (cherry picked from commit 0c78f8a) # Conflicts: # x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/download_csv_dashboard.snap
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
… (#137040) * [Discover] Fix flattening of _source fields of objects (#136473) - when fetching _source nested objects like obj.rootKey.subkey1, object.rootKey.subkey2 were not flattened correctly (cherry picked from commit 0c78f8a) # Conflicts: # x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/download_csv_dashboard.snap * [Discover] update snapshot
Summary
Fixes #123169, #127899
Before:
After:
Test:
Create an data view in management and use in in Discover
When expanding a document
action
looks like this:Checklist