Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom keyboard navigation in datepicker #13644

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Remove custom keyboard navigation in datepicker #13644

merged 1 commit into from
Aug 23, 2017

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 22, 2017 •
edited
Loading

Release Note: Remove the custom keyboard navigation in the datepicker, because it broke accessibility.

This PR removes the custom keyboard interaction, as discussed.
I basically just removed the keydown handler. Since we are going to replace it by something else (see #13525), and it's actually Angular UI bootstrap code, I didn't try to find all possible dead code paths now to remove them.

Fix #12343

@timroes
Copy link
Contributor Author

timroes commented Aug 22, 2017

Jenkins, test this

Bargs
Bargs approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal
Copy link
Contributor

Seemingly unrelated functional test failure:

05:37:46.836        └- ✖ fail: "dashboard app dashboard tab add new visualization link adds a new visualization"
05:37:46.836        │        tryForTime timeout: [POST http://localhost:9515/session/02223f0ac29eb99cc3d612b7a6ee5ae1/element / {"using":"name","value":"visTitle"}] no such element: Unable to locate element: {"method":"name","selector":"visTitle"}

cjcenizal
cjcenizal approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timroes
Copy link
Contributor Author

timroes commented Aug 23, 2017

Jenkins, test this

@timroes
Copy link
Contributor Author

timroes commented Aug 23, 2017

Jenkins, test this ...

@timroes timroes merged commit d3a62e8 into elastic:master Aug 23, 2017
@timroes timroes changed the title Remove custom keyboard mode in datepicker Remove custom keyboard navigation in datepicker Aug 23, 2017
@timroes timroes deleted the datepicker-compliance branch August 23, 2017 14:31
timroes added a commit that referenced this pull request Aug 23, 2017
@timroes
Remove custom keyboard mode in datepicker (#13644)
59aa497
@timroes
Copy link
Contributor Author

timroes commented Aug 23, 2017

Backports:

timroes added a commit that referenced this pull request Aug 23, 2017
@timroes
Remove custom keyboard mode in datepicker (#13644)
627161f
@timroes timroes removed the review label Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargs Bargs Bargs approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@aphelionz aphelionz Awaiting requested review from aphelionz

@weltenwort weltenwort Awaiting requested review from weltenwort

Assignees
No one assigned
Labels
Project:Accessibility release_note:enhancement v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timroes @cjcenizal @Bargs @jimgoodwin