Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] integration tests docker registry more robust #136438

Merged
merged 3 commits into from
Jul 18, 2022
Merged

[Fleet] integration tests docker registry more robust #136438

merged 3 commits into from
Jul 18, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 14, 2022 •
edited
Loading

Summary

Related to #124781 #133476

That PR change the way we setup the docker registry for jest integration tests:

  • add a bigger timeout as sometime pulling from the registry seems to be really long
  • wait for docker container log line instead of doing http request as it's done in Fleet API integration tests

@nchaulet nchaulet self-assigned this Jul 14, 2022
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 14, 2022
@nchaulet nchaulet marked this pull request as ready for review July 14, 2022 19:42
@nchaulet nchaulet requested a review from a team as a code owner July 14, 2022 19:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor

Could we trigger a flaky test runner on this PR? :)

Thanks a lot for the changes Nicolas!

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

Could we trigger a flaky test runner on this PR? :)

Looks like the flaky test runner tools is not available for jest integration test only for functionnal tests.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 42d8e65 into elastic:main Jul 18, 2022
@nchaulet nchaulet deleted the fix-fleet-integration-test-more-robust branch July 18, 2022 13:42
@nchaulet nchaulet mentioned this pull request Jul 18, 2022
Closed
This was referenced Jul 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nchaulet @elasticmachine @jen-huang @kibana-ci @kpollich @kibanamachine