Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add Layer types and settings UI counters #136306

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented Jul 13, 2022

Summary

Adds UI counters to telemetry for layer types and layer settings when an existing map is opened.

When a saved map is opened in Kibana, the layer types and settings are parsed and UI counters are incremented. This PR adds support for the following counters.

Layer types

  • layer_es_agg_grids
  • layer_es_agg_hexagons
  • layer_es_agg_heatmap
  • layer_es_agg_clusters
  • layer_es_docs
  • layer_es_top_hits
  • layer_es_point_to_point
  • layer_es_tracks
  • layer_ems_basemap
  • layer_ems_region
  • layer_kbn_tms_raster
  • layer_wms
  • layer_tms_raster
  • layer_tms_mvt
  • layer_ml_anomalies - Blocked by [Maps] Add ML Anomalies layer to telemetry #136345

Document Scaling options

  • scaling_limit
  • scaling_clusters
  • scaling_mvt

Cluster/Grid/Hex Resolutions

  • resolution_coarse
  • resolution_fine
  • resolution_most_fine
  • resolution_super_fine

Join types

  • join_term

Elastic Maps Service basemap types

  • ems_basemap_auto
  • ems_basemap_dark
  • ems_basemap_roadmap
  • ems_basemap_roadmap_desaturated

@nickpeihl nickpeihl mentioned this pull request Jul 13, 2022
4 tasks
@nickpeihl nickpeihl added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 13, 2022
@nickpeihl nickpeihl marked this pull request as ready for review July 13, 2022 19:13
@nickpeihl nickpeihl requested a review from a team as a code owner July 13, 2022 19:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Its so nice having these counters updated each time a map loads. This is going to be really useful.
code review, tested in chrome

@nickpeihl nickpeihl enabled auto-merge (squash) July 20, 2022 12:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 865 868 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +4.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 80.5KB 80.7KB +193.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickpeihl nickpeihl merged commit a0df571 into elastic:main Jul 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants