Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump postcss to ^8 #136303

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Bump postcss to ^8 #136303

merged 7 commits into from
Jul 19, 2022

Conversation

@jbudz jbudz added Team:Operations Team label for Operations Team v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 13, 2022
@@ -45,8 +45,9 @@ Observations:
}

* {
-webkit-print-color-adjust: exact !important; /* Chrome, Safari, Edge */
color-adjust: exact !important; /*Firefox*/
// requires upgrade to stylint 14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up with a stylelint upgrade - there's quite a few lint errors with a base change.

@jbudz jbudz marked this pull request as ready for review July 13, 2022 19:17
@jbudz jbudz requested review from a team as code owners July 13, 2022 19:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 380.3KB 380.3KB +12.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
total size 7.7MB 7.7MB -48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review, Presentation team changes LGTM!

@jbudz jbudz merged commit 88d6440 into elastic:main Jul 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
@legrego
Copy link
Member

legrego commented Apr 11, 2023

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

legrego pushed a commit to legrego/kibana that referenced this pull request Apr 11, 2023
* Bump postcss to ^8

* fixes

* fix config path

* fix path

* cleanup

(cherry picked from commit 88d6440)

# Conflicts:
#	package.json
#	src/plugins/dashboard/public/application/embeddable/viewport/print_media/styling/_index.scss
#	yarn.lock
legrego added a commit that referenced this pull request Apr 12, 2023
# Backport

This will backport the following commits from `main` to `7.17`:
- [Bump postcss to ^8
(#136303)](#136303)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jonathan
Budzenski","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-07-19T19:06:20Z","message":"Bump
postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n*
fix config path\r\n\r\n* fix path\r\n\r\n*
cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4","branchLabelMapping":{"^v8.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","v8.4.0","ci:cloud-deploy"],"number":136303,"url":"https://github.com/elastic/kibana/pull/136303","mergeCommit":{"message":"Bump
postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n*
fix config path\r\n\r\n* fix path\r\n\r\n*
cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.4.0","labelRegex":"^v8.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/136303","number":136303,"mergeCommit":{"message":"Bump
postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n*
fix config path\r\n\r\n* fix path\r\n\r\n*
cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4"}}]}]
BACKPORT-->

---------

Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.10 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants