-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump postcss to ^8 #136303
Bump postcss to ^8 #136303
Conversation
@@ -45,8 +45,9 @@ Observations: | |||
} | |||
|
|||
* { | |||
-webkit-print-color-adjust: exact !important; /* Chrome, Safari, Edge */ | |||
color-adjust: exact !important; /*Firefox*/ | |||
// requires upgrade to stylint 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up with a stylelint upgrade - there's quite a few lint errors with a base change.
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops LGTM
💚 Build SucceededMetrics [docs]Async chunks
Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code only review, Presentation team changes LGTM!
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* Bump postcss to ^8 * fixes * fix config path * fix path * cleanup (cherry picked from commit 88d6440) # Conflicts: # package.json # src/plugins/dashboard/public/application/embeddable/viewport/print_media/styling/_index.scss # yarn.lock
# Backport This will backport the following commits from `main` to `7.17`: - [Bump postcss to ^8 (#136303)](#136303) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jonathan Budzenski","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-07-19T19:06:20Z","message":"Bump postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n* fix config path\r\n\r\n* fix path\r\n\r\n* cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4","branchLabelMapping":{"^v8.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","v8.4.0","ci:cloud-deploy"],"number":136303,"url":"https://github.com/elastic/kibana/pull/136303","mergeCommit":{"message":"Bump postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n* fix config path\r\n\r\n* fix path\r\n\r\n* cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.4.0","labelRegex":"^v8.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/136303","number":136303,"mergeCommit":{"message":"Bump postcss to ^8 (#136303)\n\n* Bump postcss to ^8\r\n\r\n* fixes\r\n\r\n* fix config path\r\n\r\n* fix path\r\n\r\n* cleanup","sha":"88d64408c93cbb7ff2e0ae5942d05577a71d1fa4"}}]}] BACKPORT--> --------- Co-authored-by: Jonathan Budzenski <[email protected]>
Changelogs:
https://github.com/webpack-contrib/postcss-loader/releases
https://github.com/postcss/gulp-postcss/releases
https://github.com/RadValentin/postcss-prefix-selector/releases
https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md
https://github.com/postcss/postcss/blob/main/CHANGELOG.md
Minimal impact on our codebase, mostly yarn.lock changes