Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Breadcrumbs not updating from service jump on service map #136144

Merged
merged 16 commits into from
Jul 19, 2022
Merged

[APM] Breadcrumbs not updating from service jump on service map #136144

merged 16 commits into from
Jul 19, 2022

Conversation

cauemarcondes
Copy link
Contributor

closes #133503

breadcrumb.fix.mov

@cauemarcondes cauemarcondes requested a review from a team as a code owner July 11, 2022 19:26
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from dgieselaar July 11, 2022 19:53
@cauemarcondes cauemarcondes requested a review from dgieselaar July 12, 2022 14:30
@cauemarcondes cauemarcondes requested a review from a team July 14, 2022 13:35
@cauemarcondes cauemarcondes requested a review from dgieselaar July 14, 2022 17:29
dgieselaar
dgieselaar reviewed Jul 19, 2022
View reviewed changes
x-pack/plugins/apm/public/components/app/dependency_detail_overview/index.tsx Outdated
}),
},
],
[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct - apmRouter and all the query parameters should be defined as dependencies. If you add useBreadcrumb to .eslintrc.js as suggested earlier you should see errors here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, forgot to update the file you mentioned. Done it here: da85a74

@cauemarcondes cauemarcondes requested a review from dgieselaar July 19, 2022 14:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +234.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar
dgieselaar approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm pretty confident we can trust the hook now 😄

@cauemarcondes cauemarcondes merged commit bca30a8 into elastic:main Jul 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2022
@cauemarcondes cauemarcondes deleted the apm-breadcrumbs branch July 19, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Breadcrumbs not updating from service jump on service map
5 participants
@cauemarcondes @elasticmachine @kibana-ci @dgieselaar @kibanamachine