[ui/routes] clone defaults before apply #13295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigFunger
approved these changes
Aug 2, 2017
jbudz
approved these changes
Aug 2, 2017
spalger
added a commit
that referenced
this pull request
Aug 2, 2017
* [ui/routes] add failing tests * [ui/routes] clone defaults before applying them * Mention issue in related tests (cherry picked from commit c68c0d6)
spalger
added a commit
that referenced
this pull request
Aug 2, 2017
* [ui/routes] add failing tests * [ui/routes] clone defaults before applying them * Mention issue in related tests (cherry picked from commit c68c0d6)
|
Thanks for the quick turnaround, as always, @spalger! |
spalger
added a commit
that referenced
this pull request
Aug 14, 2017
* [ui/routes] add failing tests * [ui/routes] clone defaults before applying them * Mention issue in related tests (cherry picked from commit c68c0d6)
|
5.6/5.6.0: e942852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13294 by cloning the route defaults before applying them