Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K7] More robust theming #13129

Merged
merged 3 commits into from
Jul 26, 2017
Merged

[K7] More robust theming #13129

merged 3 commits into from
Jul 26, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 26, 2017

New color function added. Adjusts the color vars. Documents theming goals and system.

Example

This just shows the system works. Dark globals would need to be set correctly for color contrast.

image

image

@snide snide requested a review from cjcenizal July 26, 2017 18:53
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snide snide merged commit 307d007 into elastic:k7-ui-framework Jul 26, 2017
@snide snide deleted the k7/fixcoloring branch July 26, 2017 22:13
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017
add tintOrShade() function. Adjust color vars. Document system and goals
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017
add tintOrShade() function. Adjust color vars. Document system and goals
cjcenizal pushed a commit that referenced this pull request Sep 19, 2017
add tintOrShade() function. Adjust color vars. Document system and goals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants