Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New Metric Viz #131059

Closed
wants to merge 1 commit into from
Closed

[WIP] New Metric Viz #131059

wants to merge 1 commit into from

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Apr 27, 2022

Demonstration Purposes Only

DO NOT merge
DO NOT consider this code a good code or something to follow/adhere/use/copy, it is just spaghetti code to try some assumptions

To run this locally you need to:

checkout the following elastic-charts PR elastic/elastic-charts#1658

cd elastic-charts
yarn
yarn build
cd packages/charts
# now edit the package.json file in this folder, updating the "version" to 47.0.0 
yarn pack

Now on your kibana/package.json file just point the @elastic/charts dependency to the tar.gz file created by yarn pack and run yarn kbn bootstrap --no-validate and start your kibana

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 20, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for bd635dc were not reported

History

  • 💔 Build #40868 failed cd12b3ad3df22dd2ec4fccd5e4df1d17db544e47

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 closed this Apr 5, 2023
@markov00 markov00 deleted the new_metric_viz branch April 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants