[K7] Create React Icon component. #13062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjcenizal
commented
Jul 24, 2017
•
cjcenizal
commented
cjcenizal
added
the
Team:Platform-Design
cjcenizal
force-pushed
the
k7/reactify-icon-component
branch
from
137abae to
5ddfd7b
Compare
snide
suggested changes
Jul 24, 2017
| const svgReference = type ? <use href={`#${typeToIconMap[type]}`} /> : undefined; | ||
|
|
||
| return ( | ||
| <svg |
There was a problem hiding this comment.
I'd add in a <title> tag (maybe set a default prop of {name} icon.).
Might also want an optional <description> prop.
Here's some tips for accessible SVGs https://www.sitepoint.com/tips-accessible-svg/.
|
@snide Great catch! Done. |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 16, 2017
* Create React Icon component.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 26, 2017
* Create React Icon component.
cjcenizal
added a commit
that referenced
this pull request
Sep 19, 2017
* Create React Icon component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.