Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children of buttons won't capture hover events in firefox #13015

Merged
merged 4 commits into from
Jul 24, 2017
+6 −4
Merged

Children of buttons won't capture hover events in firefox #13015

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0a55f9
Children of buttons won't capture hover events in firefox
stacey-gammon Jul 20, 2017
ca531d8
Make full screen div accessible
stacey-gammon Jul 21, 2017
352a9f7
Merge branch 'master' of https://github.com/elastic/kibana into fix/f…
stacey-gammon Jul 21, 2017
1bd7acd
Remove nested aria labels
stacey-gammon Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/core_plugins/kibana/public/dashboard/dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
<dashboard-app class="app-container dashboard-container">
<div class="fullScreenModePlaceholder">
<button
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will now need a tab index and aria label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used kbn-accessible-click, that seemed to work better, otherwise I couldn't seem to press "enter" once it was highlighted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good thinking @snide. kbn-accessible-click adds those properties under the hood, so good call @stacey-gammon.

aria-label="Exit full screen mode"
kbn-accessible-click
ng-if="fullScreenMode"
class="exitFullScreenMode"
ng-click="exitFullScreenMode()"
>
<span aria-hidden="true" class="exitFullScreenModeLogo"></span>
<span class="exitFullScreenModeLogo"></span>
<span class="exitFullScreenModeText">
Exit full screen
<span aria-hidden="true" class="kuiIcon fa fa-angle-left"></span>
<span class="kuiIcon fa fa-angle-left"></span>
</span>
</button>
</div>
</div>
<!-- Local nav. -->
<kbn-top-nav name="dashboard" config="topNavMenu">
Expand Down