Allows search when no term is defined #13005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <[email protected]>
jbudz
approved these changes
Jul 20, 2017
stacey-gammon
approved these changes
Jul 20, 2017
tylersmalley
added a commit
that referenced
this pull request
Jul 20, 2017
Signed-off-by: Tyler Smalley <[email protected]>
|
master/6.0: 3519006 |
|
This can be tested by using the search menu on dashboards, The query parameters in the bottom right should be empty for search. If you type anything in the search box a star should be appended to the term: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12618 we append an asterisk to the search term to allow for matches starting with the term. This change resulted in
undefined*when no search term was provided in managements saved objects.