update logstash data and mappings for single type #13001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickypg
added a commit
that referenced
this pull request
Jul 20, 2017
This updates the function tests by: Changing logstash_functional's _type from docs (changed in #13001) to doc. Adding the original _type (apache or nginx) as a new field named type to logstash_functional's documents. Updated the mappings to include the expected type field. Did the same for makelogs by removing _default_ and other _types in favor of doc and the new type field. Dropped the single_type setting from makelogs. Updated associated tests that were looking for _type values of apache and nginx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logstash functional archive data and mappings.json file to support single type. Fixes testing error
[illegal_argument_exception] unknown setting [index.mapping.single_type].Steps to recreate data.
npm run test:ui:server"type": "apache"and"type": "nginx"with"type": "docs"node scripts/es_archiver.js load logstash_functionalnode scripts/es_archiver.js save logstash_functional logstash-*@spalger said to merge without waiting for CI to pass.