Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update user page deep links #128722

Merged
merged 2 commits into from
Mar 29, 2022
Merged

[Security Solution] Update user page deep links #128722

merged 2 commits into from
Mar 29, 2022

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Mar 29, 2022 •
edited
Loading

issues: #128604 #128616

Summary

Update user page deep-links to reflect the latest changes.

  • It hides the host authentication deep link when usersEnabled FF is enabled
  • It shows Users 'External Alerts' deep link when usersEnabled FF is enabled
  • It shows Users 'Events' deep link when usersEnabled FF is enabled
  • It shows Users 'Authentication' deep link when usersEnabled FF is enabled

It also fixes some code style issues from #128375

Checklist

@machadoum machadoum self-assigned this Mar 29, 2022
@machadoum machadoum added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 29, 2022
@machadoum machadoum marked this pull request as ready for review March 29, 2022 09:01
@machadoum machadoum requested a review from a team as a code owner March 29, 2022 09:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum requested a review from semd March 29, 2022 09:20
semd
semd approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB -12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 249.4KB 250.1KB +734.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 53dde5f into elastic:main Mar 29, 2022
This was referenced Mar 29, 2022
Closed
Closed
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128722 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128722 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Apr 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @semd @spalger