Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Execution Context] - Adds execution context to top pages for APM logs #128688

Closed
wants to merge 16 commits into from
Closed

[Security Solution][Execution Context] - Adds execution context to top pages for APM logs #128688

wants to merge 16 commits into from

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Mar 28, 2022 •
edited
Loading

Summary

Addresses #126799

This PR introduces the client side ExecutionContextService within Security Solution. This utility is added to provide application context of client and server side interactions that are then passed on to APM.

This PR concentrates on high level routes within security solution. Individual teams may decide to on further granularity following this guidance - #126799

Testing

  • Enable APM by running export ELASTIC_APM_ACTIVE=true
  • Run Kibana locally - turn off any ad blockers (they block FE events)
  • Visit discover and query something like labels.kibana_uuid : "[YOUR UUID]" and labels.name: "securitySolutionUI"
  • If your uuid is statically set by ftr tests to 5b2de169-2785-441b-ae8c-186a1936b17d - delete your .uuid file.
  • Navigate through the security solution pages and verify that you are able to see new logs reporting front end and backend events in the pages you visited

Exceptions

Screen Shot 2022-04-13 at 2 18 49 PM

Rules Create

Screen Shot 2022-04-13 at 2 19 15 PM

Rule Edit

Screen Shot 2022-04-13 at 2 19 47 PM

Rule Details

Screen Shot 2022-04-13 at 2 19 35 PM

Rules Management

Screen Shot 2022-04-13 at 2 20 00 PM

lizozom
lizozom reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
I added a couple of comments.
Let me know if any require clarficaitons.

x-pack/plugins/security_solution/public/detections/pages/alerts/index.tsx Outdated Show resolved Hide resolved
...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/create/index.tsx Outdated Show resolved Hide resolved
...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/create/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/security_solution/public/detections/pages/alerts/index.tsx Show resolved Hide resolved
x-pack/plugins/security_solution/public/detections/pages/alerts/index.tsx Show resolved Hide resolved
@lizozom lizozom linked an issue Apr 6, 2022 that may be closed by this pull request
Propagate execution context from Security solutions #126799
Closed
@yctercero yctercero self-assigned this Apr 13, 2022
@yctercero yctercero added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Alerts Security Detection Alerts Area Team v8.3.0 labels Apr 13, 2022
@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member

@elasticmachine merge upstream

@xcrzx
Copy link
Contributor

xcrzx commented May 9, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 9, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / endpoint endpoint list when there is data, "before all" hook for "finds page title"
  • [job] [logs] FTR Configs #29 / endpoint endpoint list when there is data, "before all" hook for "finds page title"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@xcrzx
Copy link
Contributor

xcrzx commented May 11, 2022

@yctercero Thanks a lot for your efforts and the initial implementation! As discussed, I have picked up this work and continued in a separate PR: #131805

@xcrzx xcrzx closed this May 11, 2022
@yctercero yctercero deleted the add_execution_context branch August 4, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom left review comments

Assignees

@yctercero yctercero

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate execution context from Security solutions
6 participants
@yctercero @MadameSheema @xcrzx @kibana-ci @lizozom @kibanamachine