-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the experimental metrics_entities
plugin by default.
#115460
Disable the experimental metrics_entities
plugin by default.
#115460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE: the matrix question. This plugin was disabled by default previously, though with the changes that had gone in around changing configs in platform, it had since become enabled by default in master. So it's my understanding that this change would just maintain the status quo for this plugin.
I noticed that rule-registry
had been on the list as not needing to be disable-able. Are we a go with it for 7.16/8.0?
Wondering if there's documentation updates needed? (That can obv be post FF).
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
From reading this comment on the original issue I understand that this code is responsible for determining if a plugin is enabled. From my understanding of that code, I assume that
|
No, you can see here in 7.15:
|
@FrankHassanabad confirmed that it was disabled by default in 7.15. Thanks! I think we can defer the decision to add user docs and I'll follow up with the cloud/dockerlist question after merge. |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💔 Backport failed
To backport manually run: |
…115460) (#115694) * Disable the experimental `metrics_entities` plugin by default. (#115460) This was default disabled in 7.15, but we needed a code change to maintain that (consistent) behavior. # Conflicts: # x-pack/plugins/metrics_entities/server/index.ts * Remove old config for metrics * Remove unused imports Co-authored-by: Robert Austin <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
Disable the experimental
metrics_entities
plugin by default. This is required due to the following change: #89584TODO
Checklist
Unit or functional testswere updated or added to match the most common scenariosRisk Matrix
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers