-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workplace Search] Migrate Objects and assets from Source settings to Synchronization section #113982
Merged
scottybollinger
merged 9 commits into
elastic:master
from
scottybollinger:scottybollinger/sync-sched-2
Oct 5, 2021
Merged
[Workplace Search] Migrate Objects and assets from Source settings to Synchronization section #113982
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
27feb9c
Rename method
scottybollinger 3ab44e2
Wire up Enable Synchronization toggle
scottybollinger 818d52d
Remove sync controls from source settings
scottybollinger c314747
Refactor to pass in contentSource as prop
scottybollinger f91ca81
Add logic for Objects and assets view
scottybollinger 7fbff8b
Add content to Objects and assets view
scottybollinger a3a543f
Add fallback for `nextStart` that is in the past
scottybollinger cef471b
reduce -> map
scottybollinger dd7e6e2
Fix casing on i18n ID
scottybollinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use camelCase here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!