-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Support multiple route paths in useApmParams #109370
[APM] Support multiple route paths in useApmParams #109370
Conversation
Pinging @elastic/apm-ui (Team:apm) |
When supplying multiple routes to My gut feeling is that this will be more confusing than useful. For re-usable components that's used across different routes, I think the "react-way" is to pass the params as props. |
@sqren it will be a union type. My first guess was also to pass these props down from components that are guaranteed to be on one route, but it's pretty annoying to pass upwards of 10 query parameters down multiple components, especially when some of those parameters are optional, making it easy to forget about them. |
@elasticmachine merge upstream |
@@ -10,6 +10,7 @@ import '../../../typings/rison_node'; | |||
import '../../infra/types/eui'; | |||
// EUIBasicTable | |||
import '../../reporting/public/components/report_listing'; | |||
import '../../reporting/server/lib/puid'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed for the typescript optimisation script
💛 Build succeeded, but was flaky
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dario Gieselaar <[email protected]>
Summary
Support multiple route paths in
useApmParams
, which is useful when a component is expected to be rendered on multiple pages: