disable execution_context service by default #108534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mshustov
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
added
the
auto-backport
afharo
approved these changes
Aug 16, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 16, 2021
Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 16, 2021
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the @dmlemeshko measurements, the execution_context usage affects response time by 17-19% #102706 (comment)
I suggest disabling the service by default. Users can opt-in by settings
execution_context.enabled: truein the config file.In the following release, having
execution_contextservice implementation refactored and nodejs version upgraded, we should be able to reduce the performance overhead and make the service enabled by default.