Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fix Copy To Permission & Unskip RBAC tests #100616

Merged
merged 4 commits into from
Jun 3, 2021
Merged

[Dashboard] Fix Copy To Permission & Unskip RBAC tests #100616

merged 4 commits into from
Jun 3, 2021

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented May 25, 2021 •
edited
Loading

Fixes #100449

Summary

This PR Fixes a typo that was causing the the copy to action to show up when the user did not have edit permissions for dashboards. It also introduces some new typing for dashboard capabilities to avoid this sort of issue in the future.

This PR also unskips the dashboard RBAC tests, which have been skipped due to flakiness.

Fixes #98249
Fixes #86950

The following Flaky Test Runner covers both flaky tests. 100 executions with 0 failures

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels May 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 327.8KB 327.9KB +113.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review June 3, 2021 14:25
@ThomThomson ThomThomson requested a review from a team as a code owner June 3, 2021 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:fix v7.14.0 v8.0.0 labels Jun 3, 2021
poffdeluxe
poffdeluxe approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm my only thought is that we have showWriteControls in one place and hideWriteControls in another. We might consider picking one name and going with it

@ThomThomson
Copy link
Contributor Author

Yeah that's been there for a really long time, and was what caused the confusion in the first place. I am planning to rename everything showWriteControls as part of the services abstraction PR.

@ThomThomson ThomThomson merged commit a0c20ac into elastic:master Jun 3, 2021
@ThomThomson ThomThomson added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 3, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 100616

@ThomThomson ThomThomson mentioned this pull request Jun 3, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Jun 3, 2021
@ThomThomson
[Dashboard] Fix Copy To Permission & Unskip RBAC tests (elastic#100616)
0854b8e 
* slightly better typing for dashboard permissions. Fixed typo, unskipped functional tests
# Conflicts:
#	x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts
@ThomThomson ThomThomson removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 3, 2021
ThomThomson added a commit that referenced this pull request Jun 3, 2021
@ThomThomson
[Dashboard] Fix Copy To Permission & Unskip RBAC tests (#100616) (#10…
87f3e63 
…1311)

* slightly better typing for dashboard permissions. Fixed typo, unskipped functional tests
# Conflicts:
#	x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts
@nreese nreese mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@ThomThomson @kibanamachine @elasticmachine @poffdeluxe