[Fleet] Info popup for installing fleet server shows up even when fleet server is available

[mukeshelastic]

Description of the problem including expected versus actual behavior:
The info popup shown below always appears until user checks do not show this again. The title of the pop up is you must install fleet-server, which on cloud is always installed unless user explcitely removes apm. I can see that in my case it was installed and I can see the elastic agent installed with elastic-cloud policy. The info message tells users that the existing agents are unenrolled and you'd need to re-enroll them, which is great. Unfortunately even after I re-enroll the agents, the message continues to stay there. Also the automatically un-enrolled agents continue to appear as inactive and there isn't a way to remove them from fleet UI.

Expected behavior:

1. If fleet-server is detected then message should only say that you'd need to re-enroll the agents.
2. Once the agents are re-enrolled, the message should disappear and the inactive agents should disappear.

Steps to reproduce:

1. Create 7.12-snapshot deployment
2. Enroll agent in fleet
3. upgrade the deployment to 7.13
4. Visit the fleet app

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Describe the feature:

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[nchaulet]

@mukeshelastic (cc @hbharding) We tried to avoid too much variation of the text here as

In cloud

Fleet Server is now available and it provides improved scalability and security. If you already had APM on Elastic Cloud, we've upgraded it to APM & Fleet. Your existing Elastic Agents have been automatically unenrolled and have stopped sending data. To continue using Fleet, you must install a Fleet Server and the new version of Elastic Agent on each host. Learn more in our Fleet Server migration guide.

Should we remove you must install a Fleet Server here? as in cloud normally Fleet Server is setup for the user.

On premise

Fleet Server is now available and it provides improved scalability and security. Your existing Elastic Agents have been automatically unenrolled and have stopped sending data. To continue using Fleet, you must install a Fleet Server and the new version of Elastic Agent on each host. Learn more in our Fleet Server migration guide.

Also the modal is show until you click on the do not "show the message again".

[nchaulet]

inactive agents should disappear

Inactive agents (agents that are unenrolled) never disappear from the UI, we could eventually add a delete action that will permanently delete the record for cleanup purpose.

[mukeshelastic]

Sounds good on the inactive agents part. But I'd expect us to not show up the message to install fleet-server when it is installed. And only tell users repeatedly that they'd need to re-enroll agents.

@mostlyjason I'd consider changing this message based on that logic important for 7.13. Let me know if you think otherwise.

[mostlyjason]

Thanks for catching this @mukeshelastic! The original issue called for a title saying "Enroll your agents into Fleet Server" #95445. However, this changed in the Figma design. CC @hbharding. +1 on hiding it after the user enrolls an agent other than the fleet server.

[EricDavisX]

@dikshachauhan-qasource @amolnater-qasource can you please review this and the relating PR and adjust tests as needed when it is merged for 7.13

[mostlyjason]

Just read some more and it sounds this was done to reduce the number of variations. A significant percentage of deployments do not have APM yet so they will need to add one.

@nchaulet could we change the text for cloud deployments based on whether a fleet server is enrolled or not? This will allow us to provide more specific instructions.

If they do have Fleet Server it should say:

Enroll your agents into Fleet Server
Fleet Server is now available and it provides improved scalability and security. We've automatically added Fleet to your APM instance. Your existing Elastic Agents have been automatically unenrolled and have stopped sending data. To continue using Fleet, you must install the new version of Elastic Agent on each host.

This is a breaking change, which is why we are making it in a beta release. We are sorry for the inconvenience. Please share feedback if you have questions or need help.

If they don't have Fleet server it should say:

This version of Fleet requires a Fleet Server
Fleet Server is now available and it provides improved scalability and security. Your existing Elastic Agents have been automatically unenrolled and have stopped sending data. To continue using Fleet, you must add a free instance of APM & Fleet in the Cloud console. Then, install the new version of Elastic Agent on each host.

This is a breaking change, which is why we are making it in a beta release. We are sorry for the inconvenience. Please share feedback if you have questions or need help.

[nchaulet]

I think changing the title make sense for both case with Fleet Server setup or not Enroll your agents into Fleet Server and to enroll agents user will have to close the modal where we show the screen that say to setup fleet server and link to edit a deployment in cloud.

We could add a new text variation, but this means more condition, more information to fetch, more surface to have bugs

[mostlyjason]

That is a tough tradeoff. We originally wanted this modal to be simple because we didn't want to invest a lot in the migration. How about this for a single variation on Cloud?

Enroll your agents into Fleet Server
Fleet Server is now available and it provides improved scalability and security. If you already had an APM instance on Elastic Cloud, we've upgraded it to APM & Fleet. If not, you can add one to your deployment for free. Your existing Elastic Agents have been automatically unenrolled and have stopped sending data. To continue using Fleet, you must use Fleet Server and install the new version of Elastic Agent on each host.

This is a breaking change, which is why we are making it in a beta release. We are sorry for the inconvenience. Please share feedback if you have questions or need help.

[mukeshelastic]

Good stuff @mostlyjason
One minor feedback on the text:

Why do we need to say you must use fleet server? Can we just say "To continue using Fleet, you must re-enroll the new version of Elastic Agent on each host" This requires the availability of fleet server so we don't need to necessarily call that explicitely.

[mostlyjason]

@mukeshelastic it used to say that Fleet server is required in the title, but we removed that. Saying that its required provides an explanation for why their agents have been unenrolled. If it were optional, they may expect their agents to continue running as before. I figured it'd be good to be explicit.

[mukeshelastic]

Fleet server is an implementation detail to users unless it doesn't exist. When it exists, we just tell them to re-enroll the agents and hopefully the documentation link shows them how, just in case it isn't clear to them.