Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up Migrations v2 Implementation into multiple files #99479

Closed
joshdover opened this issue May 6, 2021 · 1 comment · Fixed by #101200
Closed

Break up Migrations v2 Implementation into multiple files #99479

joshdover opened this issue May 6, 2021 · 1 comment · Fixed by #101200
Assignees
@TinaHeiligers
Labels
chore project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@joshdover
Copy link
Contributor

joshdover commented May 6, 2021 •
edited
Loading

The Migrations v2 implementation still has actions and tests in very large files. These should be split up to make navigating the code easier for developers to keep maintainability of this critical code high.

Specifically we should split up these files:

  • src/core/server/saved_objects/migrationsv2/actions/index.ts should be split into one file per action
  • src/core/server/saved_objects/migrationsv2/actions/index.test.ts should be split into one file per action
@joshdover joshdover added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient labels May 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover mentioned this issue May 6, 2021
Closed
17 tasks
@joshdover joshdover changed the title Cleanup Migrations v2 Implementation Break up Migrations v2 Implementation into multiple files May 26, 2021
@TinaHeiligers TinaHeiligers self-assigned this May 31, 2021
@TinaHeiligers TinaHeiligers mentioned this issue Jun 2, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
chore project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Splits migrationsv2 actions and unit tests into separate files TinaHeiligers/kibana
3 participants
@joshdover @TinaHeiligers @elasticmachine