Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named arguments in Migration actions #99242

Closed
mshustov opened this issue May 4, 2021 · 2 comments · Fixed by #100964
Closed

Use named arguments in Migration actions #99242

mshustov opened this issue May 4, 2021 · 2 comments · Fixed by #100964
Assignees
@TinaHeiligers
Labels
project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0

Comments

@mshustov
Copy link
Contributor

mshustov commented May 4, 2021

Some migrationsv2 actions have a large number of arguments, we should switch to named arguments usage to simplify reading. It's better to perform one-off renaming for all the actions and their tests.
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient labels May 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover mentioned this issue May 6, 2021
Closed
17 tasks
@TinaHeiligers TinaHeiligers self-assigned this May 28, 2021
@TinaHeiligers
Copy link
Contributor

FYI, I've started this work.

@TinaHeiligers TinaHeiligers mentioned this issue May 29, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[so-migrationsv2] Use named arguments in migrationsv2 actions TinaHeiligers/kibana
3 participants
@mshustov @TinaHeiligers @elasticmachine