Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop/pause all in-flight search requests #98965

Closed
Tracked by #166068
wylieconlon opened this issue Apr 30, 2021 · 5 comments
Closed
Tracked by #166068

Stop/pause all in-flight search requests #98965

wylieconlon opened this issue Apr 30, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@wylieconlon
Copy link
Contributor

I have seen two requests for this feature in the last day, for example this discuss user. Even though most searches are auto-cancelled when you make a change, users seem to be unaware that this is happening.

The main reasons for users to ask this seem to be:

  1. They have realized they made a mistake, and want to make changes to their configuration
  2. They want to interact with the data that is already available, without new data changing what they see

In terms of potential interfaces, here is a rough idea of how this could be implemented:

  • Keyboard shortcut to pause searches. This was explicitly requested by a user.
  • Pause button
  • Visual indicator that UI changes are cancelling older searches
@wylieconlon wylieconlon added Feature:Search Querying infrastructure in Kibana enhancement New value added to drive a business result Team:AppServices labels Apr 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant
Copy link
Contributor

Dosant commented May 3, 2021

While searches still in progress you can use search session UI to "stop a session". Search requests that support abort would be stopped

Screen Shot 2021-05-03 at 11 38 34

Seems like this is covering the request?

@wylieconlon
Copy link
Contributor Author

@Dosant I agree that this is a good start, but I don't think this is as complete as it could be: search sessions are not used in every app/solution, and it also takes multiple clicks to get there. For example, we can't stop requests from Lens, or from SIEM. We also can't use a keyboard shortcut yet. Maybe there is a way to rewrite this issue or clarify what is left to do?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 1, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 20, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Search Sessions and removed Team:AppServicesSv labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added loe:large Large Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed loe:small Small Level of Effort impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 23, 2023
@kertal kertal added the Icebox label Oct 25, 2023
@kertal
Copy link
Member

kertal commented Oct 25, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

6 participants