Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Minimize impact on page load bundle of rule registry #97128

Closed
dgieselaar opened this issue Apr 14, 2021 · 1 comment · Fixed by #97251
Closed

[RAC] Minimize impact on page load bundle of rule registry #97128

dgieselaar opened this issue Apr 14, 2021 · 1 comment · Fixed by #97251
Assignees
@dgieselaar
Labels
apm:rac Team:APM All issues that need APM UI Team support Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete v7.13.0

Comments

@dgieselaar
Copy link
Member

The rule registry has a pretty big impact on the page load bundle:

id before after diff
apm 22.2KB 53.5KB +31.3KB
observability 35.1KB 39.0KB +3.9KB
ruleRegistry - 90.8KB +90.8KB
total +126.0KB

This might be because of the ecs field map that's imported. We might be able to get by by just importing the type from the server code, which should help. There's also the possibility of some kind of a dynamic import.
@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support v7.13.0 Theme: rac label obsolete labels Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar self-assigned this Apr 14, 2021
@dgieselaar dgieselaar mentioned this issue Apr 14, 2021
Merged
@dgieselaar dgieselaar added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Apr 14, 2021
@dgieselaar dgieselaar mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
apm:rac Team:APM All issues that need APM UI Team support Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rule registry bundle size dgieselaar/kibana
3 participants
@sorenlouv @dgieselaar @elasticmachine