Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Table pagination #96778

Closed
flash1293 opened this issue Apr 12, 2021 · 7 comments · Fixed by #118557
Closed

[Lens] Table pagination #96778

flash1293 opened this issue Apr 12, 2021 · 7 comments · Fixed by #118557
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The Lens data table uses virtualized scrolling to handle large tables. However in some cases it's easier to use pagination to step through your data.

This could be offered as an optional setting on chart level.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Apr 12, 2021
29 tasks
@wylieconlon
Copy link
Contributor

I agree that we should offer this, but let's also try to clarify in the language some of the common types of pagination that this does not do:

  1. Pagination does not improve performance of queries, as all the data is loaded up front
  2. The pages don't represent the "full data set", like if you had a SQL pagination
  3. Pagination will affect how the chart is rendered to PDF/PNG reporting

@flash1293 flash1293 added the good first issue low hanging fruit label Jun 17, 2021
@drewdaemon drewdaemon self-assigned this Nov 11, 2021
@drewdaemon
Copy link
Contributor

drewdaemon commented Nov 11, 2021

From convo with @flash1293: the current table page shouldn't survive a navigation event or a browser page refresh, however it must survive a dashboard data refresh.

@drewdaemon
Copy link
Contributor

drewdaemon commented Nov 11, 2021

@flash1293 @ghudgins — also worth noting that the underlying component optionally supports user-facing page size configuration UI.

Screen Shot 2021-11-11 at 2 05 16 PM

@flash1293
Copy link
Contributor Author

@andrewctate good point - to me it seems like the Lens toolbar is a better place for this as it seems like we would anyway need a switch there to turn pagination on so its simpler to put the page size in there as well, but no strong opinion from my side how this setting is exposed.

@ghudgins
Copy link
Contributor

if pagination is enabled it would be cool for this to then show up at the bottom of the table where it is in other places. mirrors the fact we don't put sort options in the lens toolbar

@drewdaemon
Copy link
Contributor

drewdaemon commented Nov 11, 2021

It feels like we're moving toward a toggle switch in the toolbar. Either you want pagination or you don't. If you toggle pagination on, the page size options on the bottom left of the table show up.

Screen Shot 2021-11-11 at 4 09 37 PM

What do ya'll think? (the text in the screenshot is just something I plopped in there) Do ya'll agree with my train of thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants