Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Disable Delete Policy button for Managed Policies #96492

Closed
Zacqary opened this issue Apr 7, 2021 · 7 comments
Closed

[Fleet] Disable Delete Policy button for Managed Policies #96492

Zacqary opened this issue Apr 7, 2021 · 7 comments
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Apr 7, 2021

Policies marked with the is_default flags have their Delete button grayed out in the UI. Policies marked with is_managed also cannot be deleted, but the Delete button is available.

Clicking Delete will throw an error, but we should disable the button so that the user can't even get that far.

@Zacqary Zacqary added Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 labels Apr 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@nchaulet
Copy link
Member

nchaulet commented Apr 7, 2021

Should we disable deleting the default fleet server policy too (is_default_fleet_server flag on the policy) ?

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 7, 2021

@nchaulet Yes definitely. I just tested it and it looks like the Default Fleet Server policy can be deleted. That's not good.

@jfsiii
Copy link
Contributor

jfsiii commented Apr 7, 2021

I believe this is covered under #91906

I removed it from the settings tab on the policy details view in #96337 (still draft atm)

I wondered about the Default Fleet Server Policy when I was doing that. I can update it in that PR

@hbharding
Copy link
Contributor

Hey just setting this. As John mentioned, these (and many other) actions related to hosted agent policies are already accounted for. We decided to hide (rather than disable) the actions since there is nothing the user can do to enable them. Related to this, I opened an issue so that we do the same thing for policies that are marked is_default #95226

@ruflin
Copy link
Contributor

ruflin commented Apr 19, 2021

Closing as I assume this is covered in #91906.

@ruflin ruflin closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0
Projects
None yet
Development

No branches or pull requests

6 participants