Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest/lens] Switch to jest-environment-jsdom #95202

Closed
spalger opened this issue Mar 23, 2021 · 2 comments · Fixed by #95327
Closed

[jest/lens] Switch to jest-environment-jsdom #95202

spalger opened this issue Mar 23, 2021 · 2 comments · Fixed by #95327
Labels
chore Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@spalger
Copy link
Contributor

spalger commented Mar 23, 2021

Part of #95198

As we upgraded to jest-environment-jsdom tests in x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/ started failing with the following errors:

21:51:33  Summary of all failing tests
21:51:33   FAIL  x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.test.tsx
21:51:33    ● Test suite failed to run
21:51:33  
21:51:33      "messageParent" can only be used inside a worker
21:51:33  
21:51:33        at messageParent (node_modules/jest-worker/build/workers/messageParent.js:46:11)
21:51:33  
21:51:33   FAIL  x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/config_panel.test.tsx
21:51:33    ● Test suite failed to run
21:51:33  
21:51:33      "messageParent" can only be used inside a worker
21:51:33  
21:51:33        at messageParent (node_modules/jest-worker/build/workers/messageParent.js:46:11)

To unblock the upgrade this Jest project was pinned to jest-environment-jsdom-thirteen which is outdated and should be removed.

@spalger spalger added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Contributor

dej611 commented Mar 24, 2021

I thought at first it may have been a circular dependency issue here, as I've seen in other tests, but those messages are hiding the original test failures in those two suites: skipping specific tests the original errors will bubble up.
I've made a PR to address the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants