Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Formula: KQL autocomplete in formula #94673

Closed
flash1293 opened this issue Mar 16, 2021 · 3 comments
Closed

[Lens] Formula: KQL autocomplete in formula #94673

flash1293 opened this issue Mar 16, 2021 · 3 comments
Labels
discuss enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Mar 16, 2021

KQL autocomplete is a nice UX and makes it very easy to create the right query without typos. It would be helpful to have the same level of autocomplete when typing KQL in the formula. To do this, the autocomplete logic (without the UI) has to be hooked into the autocomplete API of monaco.

The suggestion functionality is exposed in the data plugin data.autocomplete.getQuerySuggestions()

@flash1293 flash1293 added discuss enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

One of the problems we'll need to solve here is that KQL uses double quotes pretty often, so we'll need to avoid conflicts. Another issue is that the KQL syntax accepts a wider range of characters than tinymath does so far.

Monaco autocompletion can handle the async part because of its cancellation token, which is important because KQL autocompletion is usually pretty slow.

@flash1293
Copy link
Contributor Author

Part of #99297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants