Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Rules should handle actions where connectors have isMissingSecrets: true #94128

Closed
ymao1 opened this issue Mar 9, 2021 · 4 comments · Fixed by #98618
Closed

[Alerting] Rules should handle actions where connectors have isMissingSecrets: true #94128

ymao1 opened this issue Mar 9, 2021 · 4 comments · Fixed by #98618
Assignees
Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Mar 9, 2021

In order to support import/export of connectors, we will be adding the ability to disable connectors after import and we need to ensure that rules can handle actions using disabled connectors.

1. Rules shouldn't schedule actions if connector is disabled

Rules already check whether an action is executable before scheduling actions using the isActionExecutable fn. Currently that only checks whether the action is preconfigured or whether the action type is disabled. This fn would need to be updated to also check whether the connector referenced by the action is has isMissingSecrets set to true.

2. Create/edit rule flyout should handle disabled connectors

If an action is using a broken connector (isMissingSecrets: true) or user selects a broken connector for an action, there should be some sort of indicator that the connector is broken. I'm not sure if there should be a link to the connector page to enable the connector since clicking it would navigate the user away from the rule flyout and they'd lose what changes they have made.

@ymao1
Copy link
Contributor Author

ymao1 commented Mar 9, 2021

If an action is using a disabled connector or user selects a disabled connector for action, there should be some sort of indicator that the connector is disabled.

There's a question of whether we should prevent users from selecting disabled connectors. In my opinion, I don't think we should prevent them from selecting this, just warn them that it's disabled. This would align better with imported rules with imported disabled connectors as well.

@ymao1 ymao1 added Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 added the blocked label Mar 9, 2021
@ymao1
Copy link
Contributor Author

ymao1 commented Mar 9, 2021

Blocked by #94106

@ymao1
Copy link
Contributor Author

ymao1 commented Apr 26, 2021

PR for #94106 is open so removing blocked label since you can branch off the PR

@ymao1 ymao1 removed the blocked label Apr 26, 2021
@ymao1 ymao1 changed the title [Alerting] Rules should handle actions with disabled connectors [Alerting] Rules should handle actions where connectors have isMissingSecrets: true Apr 26, 2021
@ymao1 ymao1 self-assigned this Apr 27, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
3 participants