Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /src/apm.js to its own package #93823

Closed
pgayvallet opened this issue Mar 5, 2021 · 1 comment · Fixed by #94315
Closed

Move /src/apm.js to its own package #93823

pgayvallet opened this issue Mar 5, 2021 · 1 comment · Fixed by #94315
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

In #92784, we migrated the /app/{id} endpoint from legacy to core. However the route handler needs to access the apm / rum configuration to inject it in the document's metadata. That causes an import from core to an undeclared source outside of its scope.

As we can't move the apm.js script to core (see #92784 (comment)), we should move it to a package to allow both the CLI and core to import it when they need to.

@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants