Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CSS preprocessor linting to warn against use of inline-block #9374

Closed
cjcenizal opened this issue Dec 5, 2016 · 1 comment
Closed
Labels
release_note:enhancement Team:Operations Team label for Operations Team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

This supersedes #9185.

Background

Using display: inline-block introduces subtle UI problems due to the inline-block spacing problem. Let's introduce a CSS preprocessor linter to warn developers against using this property unless absolutely necessary. This will encourage us to use alternatives, such as flexbox layout.

Considerations

We're currently using LESS, though #9192 introduces SCSS. If we don't want to use 2 linting tools, we should migrate the LESS to SCSS and then use an SCSS linter.

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. release_note:enhancement Team:Operations Team label for Operations Team labels Dec 5, 2016
@cjcenizal
Copy link
Contributor Author

cjcenizal commented Mar 12, 2018

Closing this so we can focus on EUI. Our UIs should largely depend on EUI components anyway, so this problem may not be prevalent enough to guard against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Operations Team label for Operations Team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

1 participant