[Discover] Show chart and save search, but chart isn't shown when it's opened again

[LeeDr]

Kibana version: 7.12.0 BC2

Elasticsearch version: 7.12.0 BC2

Server OS version: Ubuntu 16.04

Browser version: Edge 88 (Chromium based) (and verified on Chrome)

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): tar.gz from staging build

Describe the bug: I hide the chart in Discover and saved my search. Then I clicked Show chart and saved as a new visualization. But when I re-open that saved search the chart is not shown.

Steps to reproduce:

1. click New in Discover to get a clean starting point
2. click Hide chart
3. click Save
4. save it as something like search w/o chart
5. click Show chart
6. click Save
7. select Save as new search and name it search w/chart - at this point the page reloads without the chart 👎
8. click Show chart and the chart appears
9. save and reopen and the chart is gone again 👎
10. If I just save a new search with the chart shown, it shows every time I open it. So it seems like this might be a bug only with saving an existing search as a new one.

Expected behavior: It seems the state of the chart being shown or not is supposed to be saved in the saved search.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context: #88603

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[wylieconlon]

I believe the fix here is simple. hideChart is a boolean, but it is not always persisted to the discover state. I fixed a similar issue in this PR that we decided not to merge: #91783