-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover: Rollup index pattern doesn't work with source fetching #92362
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
This was the Request: Click to expand, it's very, very long
|
The problem here is that we're requesting |
I've discussed this with Luke offline. Given that we don't see much use-case in that specific combination of having I.e. we would like to make https://github.com/elastic/kibana/blob/master/src/plugins/data/common/search/search_source/search_source.ts#L619 conditional to only be called on non rollup index patterns. Since we have no urgency for 7.12 to get this in, I want to ask @ppisljar if app services team could just take that into their planning for 7.13, since it's a rather minor adjustment to the search source? |
Pinging @elastic/kibana-app-services (Team:AppServices) |
isn't this a regression introduced in 7.12 ? if so we should probably try to fix it ASAP (and our fix it week is next week). |
Yes it's a regression introduced in 7.12, though it should be a really nieche that ever have a valid scenario for that and I think it only fails in Discover (as the only consumer of raw documents in search source + rollup index patterns atm?) and if we fix it as above, we don't restore previous behavior, but would disable stored_fields with rollup index patterns (which to Luke and my impression is fine, but we can sync about it again if you have doubts about that). |
I'm not able to reproduce this. It looks to me like we're requesting |
Kibana version: 7.12
Describe the bug: When trying to view a rollup index pattern in Discover, the request fails if the fields API is not enabled (_source fetching)
Steps to reproduce:
Expected behavior:
Request works and shows the technical rollup documents
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: